git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] git-p4: fix faulty paths for case insensitive systems

From
Lars Schneider <larsxschneider@gmail.com>
Date
Aug 24, 2015, 12:43 UTC
Message-ID
<FB860908-F176-4EA3-A2D1-962E97BD12F7@gmail.com>
In-Reply-To
<CAE5ih78P2-oiZTY-d_5NYgchG3mh4FVy8GaNmBhicmmceU2k8w@mail.gmail.com>
Show 22 quoted lines
> 
> <snip>
> 
>> 
>> While I was working on the examples for this email reply I realized that the problem is only present for paths given in a client-spec. I added a test case to prove that. That means I don’t need to request *all* paths. I *think* it is sufficient to request the paths mentioned in the client spec which would usually be really fast. Stay tuned for PATCH v5.
> 
> I've just tried a small experiment with stock unaltered git-p4.
> 
> - Started p4d with -C1 option to case-fold.
> - Add some files with different cases of directory (Path/File1,
> PATH/File2, pATH/File3).
> - git-p4 clone.
> 
> The result of the clone is separate directories if I do nothing
> special (PATH/File1, Path/File2, etc). But if I set core.ignorecase, I
> get a single case-folded directory, Path/File1, Path/File2, etc. I'm
> still failing to get how that isn't what you need (other than being a
> bit obscure to get to the right invocation).
> 
> I've put a script that shows this here:
> 
> https://github.com/luked99/quick-git-p4-case-folding-test

As mentioned I realized that the problem occurs only if you use client specs. Can you take a look at this test case / run it? https://github.com/larsxschneider/git/blob/d3a191cb5fb4d8f5f48ca9314c772169d5dbf65b/t/t9821-git-p4-path-variations.sh#L112-L127

Does this make sense to you? If you want to I could also modify “quick-git-p4-case-folding-test” to show the problem.

Cheers, Lars

Previous: Luke DiamandNext: Luke Diamand
Message 9 of 10 in “git-p4: fix faulty paths for case insensitive systems”
  1. git-p4: fix faulty paths for case insensitive systemslarsxschneider@gmail.com, Aug 21, 2015
  2. Junio C HamanoAug 21, 2015
  3. Lars SchneiderAug 23, 2015
  4. Junio C HamanoAug 24, 2015
  5. Lars SchneiderAug 24, 2015
  6. Luke DiamandAug 23, 2015
  7. Lars SchneiderAug 24, 2015
  8. Luke DiamandAug 24, 2015
  9. Lars SchneiderAug 24, 2015
  10. Luke DiamandAug 24, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.