Re: [PATCH v4] git-p4: fix faulty paths for case insensitive systems

From: Luke Diamand <luke@diamand.org>
Date: Aug 24, 2015, 13:49 UTC
Message-ID: <CAE5ih78OAm=i6BEGpZc40EQ6MwJOcEgLHEBsEPq5XyDw6xcu2A@mail.gmail.com>
In-Reply-To: <FB860908-F176-4EA3-A2D1-962E97BD12F7@gmail.com>

On 24 August 2015 at 13:43, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 6 quoted lines

>>
>> https://github.com/luked99/quick-git-p4-case-folding-test
> As mentioned I realized that the problem occurs only if you use client specs. Can you take a look at this test case / run it?
> https://github.com/larsxschneider/git/blob/d3a191cb5fb4d8f5f48ca9314c772169d5dbf65b/t/t9821-git-p4-path-variations.sh#L112-L127
>
> Does this make sense to you? If you want to I could also modify “quick-git-p4-case-folding-test” to show the problem.

If you're able to fix my hacky test to show the problem that would be very kind.

If the problem only shows up when using client specs, is it possible that the core.ignorecase logic is just missing a code path somewhere?

Glancing through the code, stripRepoPath() could perhaps be the culprit? If self.useClientSpec is FALSE, it will do the core.ignorecase trick by calling p4PathStartsWith, but if it is TRUE, it won't.

Thanks! Luke