Re: [PATCH 1/3] reflog: libify delete reflog function and helpers

From: John Cai <johncai86@gmail.com>
Date: Feb 23, 2022, 19:50 UTC
Message-ID: <F889CE8D-BFFD-4E3D-8CD1-0F2A1948805F@gmail.com>
In-Reply-To: <YhLv9P9VFQ6Iwv41@nand.local>

Hi Taylor,

On 20 Feb 2022, at 20:50, Taylor Blau wrote:

Show 16 quoted lines

> On Sun, Feb 20, 2022 at 08:43:14PM -0500, John Cai wrote:
>>> One question that I had which I don't see answered already is what the
>>> plan is for existing reflog-related functions that live in refs.h.
>>> Should or will those functions be moved to the new reflog-specific
>>> header, too?
>>
>> Thanks for bringing ths up! Maybe this cleanup can be included in a separate
>> patch series since this one is mainly about getting rid of the shell-out in
>> stash.c. What do you think?
>
> Yeah; I think that's fine. We don't need to get all reflog-related
> functions moved into reflog.h in the first series, so I think it's fine
> to move things as you discover them.
>
> I was just wondering whether it was something you planned to do at some
> point (as part of this series, or a future one).

Yes I will open a new series for this. I've been looking through refs.h, and as you alluded to there are a number of reflog related functions. But, they also relate to refs. I'm not sure which ones should go into reflog.h versus staying in refs.h. What are your thoughts?

>
> Thanks,
> Taylor

Thanks! John