Re: [PATCH v3 0/3] libify reflog

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 2, 2022, 18:55 UTC
Message-ID: <220302.86a6e86v35.gmgdl@evledraar.gmail.com>
In-Reply-To: <69041BB1-569D-4462-A1CE-2F1BDA9A76C0@gmail.com>

On Wed, Mar 02 2022, John Cai wrote:

> Just wanted to bump this thread. It'd be good to get another ack on these
> last set of changes.

Hi. Sorry that I didn't look at it earlier.

This looks good to me and I think everything that's been brought up has been addressed.

I left a nit on 1/3 suggesting a way to make that diff a bit smaller by using a subshell instead of refactoring an existing function.

But I think with or without that & a ro-roll this would be good to advance to "next" etc.

Thanks!

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.