Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP

From: Philip Oakley <philipoakley@iee.org>
Date: Mar 4, 2013, 00:12 UTC
Message-ID: <F455D17A40C2498C84F85E2937B732AC@PhilipOakley>
In-Reply-To: <7v4ngsyqpx.fsf@alter.siamese.dyndns.org>

From: "Junio C Hamano" <gitster@pobox.com>
Sent: Monday, March 04, 2013 12:05 AM

Show 15 quoted lines

> "Philip Oakley" <philipoakley@iee.org> writes:
>
>>> Hrm, I do not recall anybody ever declared that "--all" is 
>>> deprecated.
>>
>> No, it was the use OPT_COUNTUP rather than OPT_BOOLEAN that the
>> deprecated' was refering to.
>
> Oh, no OPT_BOOLEAN was deprecated because too many people rightfully
> thought it was about 0/1 choice and got burned by its count-up
> behaviour.  When you want to count-up, OPT_COUNTUP is the right
> thing to do and replacing deprecated BOOLEAN with it is a correct
> thing to do.  But for this optoin, I do not think you want to count
> up in the first place.  You want a 0/1 choice, which is written as
> OPT_BOOL these days.

Ah, I missed that.

Though, for the longer term --guides usage, I'd envisaged that having it a second time could be used to invoke some extra search code that would list all guides, rather than just the short list of common guides. But I'm not sure how best to determine what are valid guides, including Msysgit/Git4Windows which only uses the html versions (no man command), so I'll use OPT_BOOL initially.

Philip