Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2013, 23:38 UTC
Message-ID: <7vwqtoyryp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1362342072-1412-3-git-send-email-philipoakley@iee.org>

Philip Oakley <philipoakley@iee.org> writes:

> rename deprecated option in preparation for 'git help --guides'.

s/rename/Rename/;

>
> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---

Hrm, I do not recall anybody ever declared that "--all" is deprecated.

I do not think we want --all and --all --all to be different, and we certainly do not want --all --no-all to be not-all, so I cannot tell what you want to achieve with this change at all, either from the patch or the proposed log message.

Show 16 quoted lines

>  builtin/help.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/help.c b/builtin/help.c
> index d1d7181..d10cbed 100644
> --- a/builtin/help.c
> +++ b/builtin/help.c
> @@ -39,7 +39,7 @@ static int show_all = 0;
>  static unsigned int colopts;
>  static enum help_format help_format = HELP_FORMAT_NONE;
>  static struct option builtin_help_options[] = {
> -	OPT_BOOLEAN('a', "all", &show_all, N_("print all available commands")),
> +	OPT_COUNTUP('a', "all", &show_all, N_("print all available commands")),
>  	OPT_SET_INT('m', "man", &help_format, N_("show man page"), HELP_FORMAT_MAN),
>  	OPT_SET_INT('w', "web", &help_format, N_("show manual in web browser"),
>  			HELP_FORMAT_WEB),