Re: [PATCH/RFC] Fix some warnings (on cygwin) to allow -Werror

From

Steffen Prohaska <prohaska@zib.de>

Date

Jul 4, 2008, 09:46 UTC

Message-ID

<E4D3A379-9EB2-49D1-AD42-CFFC453A2B08@zib.de>

In-Reply-To

<486CF5A9.5060104@ramsay1.demon.co.uk>

On Jul 3, 2008, at 5:52 PM, Ramsay Jones wrote:

>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Despite the subject line, this should be useful on any system for
> which uint32_t is defined to be unsigned long rather than
> unsigned int. (and where the return type of htonl() is similarly
> defined).

For MINGW, we fixed these warnings in the compat layer, see cd800eecc2:

diff --git a/compat/mingw.h b/compat/mingw.h
index a87cc96..6bc049a 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -186,6 +186,10 @@ pid_t mingw_spawnvpe(const char *cmd, const char  
**argv, char **env);
  void mingw_execvp(const char *cmd, char *const *argv);
  #define execvp mingw_execvp

+static inline unsigned int git_ntohl(unsigned int x)
+{ return (unsigned int)ntohl(x); }
+#define ntohl git_ntohl
+
  sig_handler_t mingw_signal(int sig, sig_handler_t handler);
  #define signal mingw_signal

	Steffen