Re: [PATCH/RFC] Fix some warnings (on cygwin) to allow -Werror

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 4, 2008, 08:59 UTC
Message-ID: <7vskuquisp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <486CF5A9.5060104@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> Despite the subject line, this should be useful on any system for
> which uint32_t is defined to be unsigned long rather than
> unsigned int. (and where the return type of htonl() is similarly
> defined).

Correct.  Perhaps "Use %PRIu32 and such to print integers of fixed length"?

The only worry I have with this patch is with systems with not-so-ANSI headers; as you noticed, we already have:

        #ifndef PRIuMAX
        #define PRIuMAX "llu"
        #endif

in git-compat-util.h, which does include <inttypes.h>, so PRIu32 and friends could be problematic on these platforms.

Show 7 quoted lines

> @@ -1718,7 +1720,8 @@ static int add_ref_tag(const char *path, const unsigned char *sha1, int flag, vo
>  static void prepare_pack(int window, int depth)
>  {
>  	struct object_entry **delta_list;
> -	uint32_t i, n, nr_deltas;
> +	uint32_t i, nr_deltas;
> +	unsigned n;

Hmm.  Is this change necessary?