Re: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

From: Philip Oakley <philipoakley@iee.org>
Date: Jan 14, 2018, 17:25 UTC
Message-ID: <E2F9FAE97F7D4B49A5A644FC796A9AAC@PhilipOakley>
In-Reply-To: <20180114164529.10120-1-randall.s.becker@rogers.com>

From: <randall.s.becker@rogers.com>
Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused 
compile warnings

s/Remoted/Removed/ ?

Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the superflous spaces) -- Philip

Show 36 quoted lines

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> * The while loop in the inline method hashmap_enable_item_counting
>  used an unneeded variable. The loop has been revised accordingly.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> hashmap.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hashmap.h b/hashmap.h
> index 7ce79f3..d375d9c 100644
> --- a/hashmap.h
> +++ b/hashmap.h
> @@ -400,7 +400,6 @@ static inline void 
> hashmap_disable_item_counting(struct hashmap *map)
>  */
> static inline void hashmap_enable_item_counting(struct hashmap *map)
> {
> - void *item;
>  unsigned int n = 0;
>  struct hashmap_iter iter;
>
> @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct 
> hashmap *map)
>  return;
>
>  hashmap_iter_init(map, &iter);
> - while ((item = hashmap_iter_next(&iter)))
> + while (hashmap_iter_next(&iter))
>  n++;
>
>  map->do_count_items = 1;
> -- 
> 2.8.5.23.g6fa7ec3
>