git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

From
Rrandall.s.becker@rogers.com <randall.s.becker@rogers.com>
Date
Jan 14, 2018, 16:45 UTC
Message-ID
<20180114164529.10120-1-randall.s.becker@rogers.com>
From: "Randall S. Becker" <rsbecker@nexbridge.com>
* The while loop in the inline method hashmap_enable_item_counting
  used an unneeded variable. The loop has been revised accordingly.
Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 hashmap.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hashmap.h b/hashmap.h
index 7ce79f3..d375d9c 100644
--- a/hashmap.h
+++ b/hashmap.h
@@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)
  */
 static inline void hashmap_enable_item_counting(struct hashmap *map)
 {
-	void *item;
 	unsigned int n = 0;
 	struct hashmap_iter iter;
 
@@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)
 		return;
 
 	hashmap_iter_init(map, &iter);
-	while ((item = hashmap_iter_next(&iter)))
+	while (hashmap_iter_next(&iter))
 		n++;
 
 	map->do_count_items = 1;
-- 
2.8.5.23.g6fa7ec3
Next: Philip Oakley
Message 1 of 3 in “Remoted unnecessary void* from hashmap.h that caused compile warnings”
  1. Remoted unnecessary void* from hashmap.h that caused compile warningsrandall.s.becker@rogers.com, Jan 14, 2018
  2. Philip OakleyJan 14, 2018
  3. Randall S. BeckerJan 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.