Re: git-daemon problem

From: Matthias Lederhofer <matled@gmx.net>
Date: Jul 12, 2006, 19:28 UTC
Message-ID: <E1G0kNV-0006LK-QW@moooo.ath.cx>
In-Reply-To: <7vlkqz1lja.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

> This breaks the newer clients that knows how to do side-band
> doesn't it?

Probably, this patch is just to give a starting point where the problem could be.

> Would this replacement patch help?

[use write instead of safe_write]

This seems to fix it.  Perhaps it should be xwrite instead of write.

> Maybe we should check if fd 2 is sane at daemon startup, and
> otherwise open /dev/null for writing and dup2 it to fd 2?

daemon startup is probably not the right place because as long as the terminal is open this will be fine.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.