From: Matthias Lederhofer <matled@gmx.net>
Date: Wed, 12 Jul 2006 19:28:09 GMT
Subject: Re: git-daemon problem
Message-ID: <E1G0kNV-0006LK-QW@moooo.ath.cx>
In-Reply-To: <7vlkqz1lja.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> This breaks the newer clients that knows how to do side-band
> doesn't it?
Probably, this patch is just to give a starting point where the
problem could be.

> Would this replacement patch help?
[use write instead of safe_write]

This seems to fix it.  Perhaps it should be xwrite instead of write.

> Maybe we should check if fd 2 is sane at daemon startup, and
> otherwise open /dev/null for writing and dup2 it to fd 2?
daemon startup is probably not the right place because as long as the
terminal is open this will be fine.