git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitweb bug: broken "next" and other links

From
Wincent Colaiuta <win@wincent.com>
Date
Feb 12, 2008, 12:24 UTC
Message-ID
<E16BED2E-C146-44D8-BD90-ECF0DF89CA35@wincent.com>
In-Reply-To
<200802111630.29159.jnareb@gmail.com>
El 11/2/2008, a las 16:30, Jakub Narebski escribió:
Show 33 quoted lines
> Dnia poniedziałek 11. lutego 2008 14:33, Wincent Colaiuta napisał:
>> El 11/2/2008, a las 14:02, Jakub Narebski escribió:
>>> Wincent Colaiuta <win@wincent.com> writes:
>>>
>>>> Just noticed a bug (possibly bugs) in gitweb.
>>>>
>>>> Look at a shortlog page like this one:
>>>>
>>>> http://repo.or.cz/w/git.git?a=shortlog
>>>>
>>>> Mouse over the "next" link at the bottom and you'll see this is the
>>>> URL:
>>>>
>>>> http://repo.or.cz/w/ARRAY(0x85a5318)?a=shortlog;pg=1
>>>>
>>>> Which obviously won't work...
>>>
>>> This is bug in repo.or.cz version of gitweb, which is slightly
>>> modified as compared to the "stock" version. Such error would be
>>> catched by the gitweb 'run as standalone script and check stderr'
>>> test script.
>>
>> Hmm. I don't know. I can reproduce all three of those bugs on my own
>> unmodified gitweb installation from 1.5.4.
>
> I'm sorry. You are right. I haven't seen breakage because it shows
> only when you use 'pathinfo' feature and pathinfo URLs.
>
> Below there is a fix for that; actully only second part mentioned
> (and first in patch) is needed, i.e. moving setting $params{'project'}
> before dealing with -replay is needed I think to fix this bug.
>
> Could you test it please?
Your patch fixes the "next" links in the shortlog and log views.

It doesn't fix the broken "raw" links in the commitdiff view. I'm still seeing links like:

http://example.com/ARRAY(0x8c97f64)?a=commitdiff_plain;h=f29d56269a1c3bd4a970897397470f41553a64f9

Cheers, Wincent

Previous: Jakub NarebskiNext: Jakub Narebski
Message 7 of 16 in “gitweb bug: broken "next" and other links”
  1. Wincent ColaiutaFeb 11, 2008
  2. Jakub NarebskiFeb 11, 2008
  3. Wincent ColaiutaFeb 11, 2008
  4. Jakub NarebskiFeb 11, 2008
  5. Jakub NarebskiFeb 12, 2008
  6. Jakub NarebskiFeb 12, 2008
  7. Wincent ColaiutaFeb 12, 2008
  8. Jakub NarebskiFeb 12, 2008
  9. Wincent ColaiutaFeb 12, 2008
  10. Jakub NarebskiFeb 15, 2008
  11. Wincent ColaiutaFeb 17, 2008
  12. Junio C HamanoFeb 17, 2008
  13. Jakub NarebskiFeb 18, 2008
  14. Junio C HamanoFeb 18, 2008
  15. Jakub NarebskiFeb 19, 2008
  16. Wincent ColaiutaFeb 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.