Re: gitweb bug: broken "next" and other links

From: Wincent Colaiuta <win@wincent.com>
Date: Feb 17, 2008, 10:51 UTC
Message-ID: <C8D96592-DD9C-47D3-93AB-3F74719F4D46@wincent.com>
In-Reply-To: <200802152216.42533.jnareb@gmail.com>

El 15/2/2008, a las 22:16, Jakub Narebski escribió:

Show 26 quoted lines

> On Tue, 12 Feb 2008, Wincent Colaiuta wrote:
>> El 11/2/2008, a las 16:30, Jakub Narebski escribió:
>
>>> Below there is a fix for that; actully only second part mentioned
>>> (and first in patch) is needed, i.e. moving setting  
>>> $params{'project'}
>>> before dealing with -replay is needed I think to fix this bug.
>
> Below there is minimal patch which I am using, which only
> moves setting $params{'project'}, and does not affect replay.
>
>>> Could you test it please?
>>
>> Your patch fixes the "next" links in the shortlog and log views.
>>
>> It doesn't fix the broken "raw" links in the commitdiff view. I'm
>> still seeing links like:
>>
>> http://example.com/ARRAY(0x8c97f64)?a=commitdiff_plain;h=f29d56269a1c3bd4a970897397470f41553a64f9
>
> WORKSFORME. I could not reproduce this error with the patch
> below applied. I think that the previous version of patch should
> give the same result; should also fix this bug.
>
> Besides, both "next" and "raw" links are generated using the same
> mechanism. It would be strange if one of them broke and other didn't.

Just re-tested again, this time applying on top of 1.5.4.2 and definitely doesn't work for me.

The "next" links are fixed, the "raw" links still exhibit the same problem.

eg. here's a commitdiff page with a broken "raw" link from my installation:

http://git.wincent.com/wikitext.git?a=commitdiff;h=03b8fda6594aa7e6fab3b95b66a4f3c178d6a156

And here's a shortlog page with now-working "next" links:

http://git.wincent.com/wikitext.git?a=shortlog;h=03b8fda6594aa7e6fab3b95b66a4f3c178d6a156

Cheers, Wincent