AW: [PATCH v3] gitk: added external diff file rename detection

> -----Ursprüngliche Nachricht-----
> Von: Johannes Sixt <j6t@kdbg.org>
> Gesendet: Sonntag, 16. März 2025 17:22
> An: Boesch, Tobias <tobias.boesch@miele.com>
> Cc: git@vger.kernel.org; ToBoMi via GitGitGadget <gitgitgadget@gmail.com>
> Betreff: Re: [PATCH v3] gitk: added external diff file rename detection
>
> Am 04.03.25 um 14:01 schrieb ToBoMi via GitGitGadget:
> > From: Tobias Boesch <tobias.boesch@miele.com>
> >
> > * If a file was renamed between commits and an external diff is started
> >   through gitk on the original or the renamed file name,
> >   gitk was unable to open the renamed file in the external diff editor.
> >   It failed to fetch the renamed file from git, because it fetched it
> >   using its original path in contrast to using the renamed path of the
> >   file.
> > * With this change gitk detects the rename and opens the external diff
> >   with the original and the renamed file instead of no file (it is able
> >   to fetch the renamed file path and name now from git).
> > * Since git doesn't destinguish between move or rename this also works
> >   for moved files.
> > * Showing the external diff with the original and the renamed file
> >   works when either of the files is selected in gitk.
> >
> > Signed-off-by: Tobias Boesch <tobias.boesch@miele.com>
> > ---
>
> I've picked up this patch, but haven't found time to look at it in detail. It will
> take some time. Please bear with me.
>
> The commit message would need to be rewritten to match our usual style:
>
> - We do not use bullet points for normal text paragraphs.
> - We describe the status quo in present tense,
> - and then the changes in imperative mood. (Like, "code, become so!")
> - The subject is not in past tense, but usually also imperative.
>
> -- Hannes