Re: [PATCH v3] gitk: added external diff file rename detection

From: Johannes Sixt <j6t@kdbg.org>
Date: Mar 16, 2025, 16:21 UTC
Message-ID: <53c5aed4-ce4f-4ad7-8e90-a97fd3c973cd@kdbg.org>
In-Reply-To: <pull.1774.v3.git.1741093275742.gitgitgadget@gmail.com>

Am 04.03.25 um 14:01 schrieb ToBoMi via GitGitGadget:

Show 18 quoted lines

> From: Tobias Boesch <tobias.boesch@miele.com>
> 
> * If a file was renamed between commits and an external diff is started
>   through gitk on the original or the renamed file name,
>   gitk was unable to open the renamed file in the external diff editor.
>   It failed to fetch the renamed file from git, because it fetched it
>   using its original path in contrast to using the renamed path of the
>   file.
> * With this change gitk detects the rename and opens the external diff
>   with the original and the renamed file instead of no file (it is able
>   to fetch the renamed file path and name now from git).
> * Since git doesn't destinguish between move or rename this also works
>   for moved files.
> * Showing the external diff with the original and the renamed file
>   works when either of the files is selected in gitk.
> 
> Signed-off-by: Tobias Boesch <tobias.boesch@miele.com>
> ---

I've picked up this patch, but haven't found time to look at it in detail. It will take some time. Please bear with me.

The commit message would need to be rewritten to match our usual style:

- We do not use bullet points for normal text paragraphs.
- We describe the status quo in present tense,
- and then the changes in imperative mood. (Like, "code, become so!")
- The subject is not in past tense, but usually also imperative.

-- Hannes