git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] notes: do not drop notes written by a concurrent process

From
Farid Zakaria <farid.m.zakaria@gmail.com>
Date
Oct 30, 2026, 19:56 UTC
Message-ID
<DMIFRWWLOTMP.3HVH81PKHBTKK@gmail.com>
In-Reply-To
<34b5c9c8-74d6-4d49-93cf-1d1909d56e9b@app.fastmail.com>
On Fri Oct 30, 2026 at 2:21 AM PDT, Kristoffer Haugsbakk wrote:
Show 19 quoted lines
> On Thu, Oct 29, 2026, at 21:56, Farid Zakaria wrote:
>> On Thu Oct 29, 2026 at 11:25 AM PDT, Junio C Hamano wrote:
>>> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>>>>[snip]
>>>
>>> Or possibly
>>>
>>>[snip]
>>
>> Your proposals for retries when possible make sense but I may leave that
>> to you to implement.
>>
>> I felt confident reviewing the current patch at it's current state
>> (AI-assisted) and I do concur that it's a net-positive change in the
>> interim.
>
> Use of GenAI should be disclosed up front.
> Documentation/SubmittingPatches, [[ai]].
>
Please consider the thread my disclosure.

FWIW I did read https://git-scm.com/docs/SubmittingPatches as of today and I don't see any specific mention of disclosure. It might be a good idea to make that explicit.

I see no mention of special trailer or mention to disclosure although it does mention rejecting anything that looks like "slop" which I hope this is not -- I went through the patch and the failure.

If I was looking at the wrong document, please point me to the right one.

Show 13 quoted lines
>>
>> (I guess I could try to implement the retry logic - AI
>> assisted if you like)
>>
>> Would it be OK if I also suggested the other two bugs (+small fixes)
>> I found on the mailing list (with the same tool)?
>>
>> They are:
>> * Similar race-type bug for credential-cache leaving a stale daemon+credential
>> * fsmonitor daemon keeps running after its worktree is deleted or moved
>>
>> Both patches are of similar size and complexity to this one, with a test
>> case.
Previous: Kristoffer HaugsbakkNext: Kristoffer Haugsbakk
Message 9 of 11 in “notes: do not drop notes written by a concurrent process”
  1. notes: do not drop notes written by a concurrent processFarid Zakaria, Oct 29, 2026
  2. Kristoffer HaugsbakkOct 29, 2026
  3. Junio C HamanoOct 29, 2026
  4. Farid ZakariaOct 29, 2026
  5. Junio C HamanoOct 29, 2026
  6. Farid ZakariaOct 29, 2026
  7. Patrick SteinhardtOct 30, 2026
  8. Kristoffer HaugsbakkOct 30, 2026
  9. Farid ZakariaOct 30, 2026
  10. Kristoffer HaugsbakkOct 31, 2026
  11. Kristoffer HaugsbakkOct 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.