Re: [PATCH] notes: do not drop notes written by a concurrent process
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Oct 30, 2026, 09:21 UTC
- Message-ID
- <34b5c9c8-74d6-4d49-93cf-1d1909d56e9b@app.fastmail.com>
- In-Reply-To
- <DMHMEOZ1ZXRI.TDMEKTJ9W325@gmail.com>
On Thu, Oct 29, 2026, at 21:56, Farid Zakaria wrote:
Show 14 quoted lines
> On Thu Oct 29, 2026 at 11:25 AM PDT, Junio C Hamano wrote: >> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes: >>>[snip] >> >> Or possibly >> >>[snip] > > Your proposals for retries when possible make sense but I may leave that > to you to implement. > > I felt confident reviewing the current patch at it's current state > (AI-assisted) and I do concur that it's a net-positive change in the > interim.
Use of GenAI should be disclosed up front. Documentation/SubmittingPatches, [[ai]].
Show 13 quoted lines
> > (I guess I could try to implement the retry logic - AI > assisted if you like) > > Would it be OK if I also suggested the other two bugs (+small fixes) > I found on the mailing list (with the same tool)? > > They are: > * Similar race-type bug for credential-cache leaving a stale daemon+credential > * fsmonitor daemon keeps running after its worktree is deleted or moved > > Both patches are of similar size and complexity to this one, with a test > case.