git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] meson: restore hook-list.h to builtin_sources

From
Matt Hunter <m@lfurio.us>
Date
Jul 3, 2026, 06:03 UTC
Message-ID
<DJOPIP6EQWWJ.H6X9L009RO1W@lfurio.us>
In-Reply-To
<CAJ0EP43gyQf_XhCLCNEzCq9wMYXZBQX=PWjR-wYqoESSvByJiA@mail.gmail.com>
On Thu Jul 2, 2026 at 1:03 PM EDT, Mike Gilbert wrote:
Show 7 quoted lines
>
> Thank you for the review. This is my first contribution to the Git
> project and I'm trying to follow the lengthy SubmittingPatches guide.
>
> I believe we have "reached a consensus" and my next steps are as follows:
>
> - Add Reviewed-by (or Acked-by?) for Patrick and Adrian.

I believe the typical etiquette is to only apply someone else's Reviewed-by trailer if it is offered to you.

> - Send the patch to Junio with the list CCed.

Generally speaking, I'd wait at least a couple days to see if _this_ copy of the patch gets picked up into the 'seen' branch, before resending for this purpose.

>

I _would_ give my thoughts on the change while I'm here, but I'm not nearly hip enough to the meson build system to leave anything useful

Welcome to the Git community
Previous: Patrick Steinhardt
Message 6 of 6 in “meson: restore hook-list.h to builtin_sources”
  1. meson: restore hook-list.h to builtin_sourcesMike Gilbert, Jul 1, 2026
  2. Adrian RatiuJul 2, 2026
  3. Patrick SteinhardtJul 2, 2026
  4. Mike GilbertJul 2, 2026
  5. Patrick SteinhardtJul 3, 2026
  6. Matt HunterJul 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.