From: Matt Hunter Date: Fri, 03 Jul 2026 06:03:12 GMT Subject: Re: [PATCH] meson: restore hook-list.h to builtin_sources Message-ID: In-Reply-To: On Thu Jul 2, 2026 at 1:03 PM EDT, Mike Gilbert wrote: > > Thank you for the review. This is my first contribution to the Git > project and I'm trying to follow the lengthy SubmittingPatches guide. > > I believe we have "reached a consensus" and my next steps are as follows: > > - Add Reviewed-by (or Acked-by?) for Patrick and Adrian. I believe the typical etiquette is to only apply someone else's Reviewed-by trailer if it is offered to you. > - Send the patch to Junio with the list CCed. Generally speaking, I'd wait at least a couple days to see if _this_ copy of the patch gets picked up into the 'seen' branch, before resending for this purpose. > I _would_ give my thoughts on the change while I'm here, but I'm not nearly hip enough to the meson build system to leave anything useful Welcome to the Git community