Re: [PATCH] guilt: Make sure the commit time is increasing

From: Theodore Tso <tytso@mit.edu>
Date: Jul 6, 2010, 10:56 UTC
Message-ID: <DD1E6EE4-1196-4FCA-87DA-EB9EBCA3AC83@mit.edu>
In-Reply-To: <20100706080322.GA2856@burratino>

On Jul 6, 2010, at 4:03 AM, Jonathan Nieder wrote:

Show 5 quoted lines

> At one point rev-list did require monotonic --- i.e., the committer
> date of each commit had to be equal to or later than that of each of
> its parents) with no clock skew but that was considered a bug and
> fixed by v1.5.5-rc1~16 (Make revision limiting more robust against
> occasional bad commit dates, 2008-03-17)

You're right that it's been a while since git has run into problems with mild forms of clock skew (even Debian Stable is shipping v1.5.6) but I think it's better to times in the future if we can at all help it, and it's not like we're talking about a lot of extra complexity to guilt to test for this.

> By the way, I think your idea to have commit warn about nonmonotonic
> commit dates is a good one.  We should also decide on a rule,
> hopefully one the kernel repo obeys (30 days max skew? *crosses
> fingers*) and make git fsck warn loudly about violations.

Having git commit warn, absolutely.

Unfortunately, there is already ~100 days of skew (see the earlier discusion on this thread by Jeff King) in the Linux kernel repo already...

-- Ted