git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] guilt: Make sure the commit time is increasing

From
Jjeffpc@josefsipek.net <jeffpc@josefsipek.net>
Date
Jul 5, 2010, 02:59 UTC
Message-ID
<20100705025900.GQ22659@josefsipek.net>
In-Reply-To
<1278296639-25024-1-git-send-email-tytso@mit.edu>
On Sun, Jul 04, 2010 at 10:23:59PM -0400, Theodore Ts'o wrote:
Show 5 quoted lines
> Git has various algorithms, most notably in git rev-list, git
> name-rev, and others, which depend on the commit time increasing.  We
> want to keep the commit time the same as much as possible, but if
> necessary, adjust the time stamps of the patch files to obey this
> constraint.

Am I understanding this right? You want the timestamps to be monotonically increasing? Is the +60 the most obvious choice?

Can I get an example of how git can get confused?
Josef 'Jeff' Sipek.
Show 26 quoted lines
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
>  guilt |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/guilt b/guilt
> index b6e2a6c..2371e98 100755
> --- a/guilt
> +++ b/guilt
> @@ -535,6 +535,13 @@ commit()
>                          export GIT_AUTHOR_EMAIL="`echo $author_str | sed -e 's/[^<]*//'`"
>  		fi
>  
> +		ct=$(git log -1 --pretty=%ct)
> +		if [ $ct -gt $(stat -c %Y "$p") ]; then
> +		    echo "Warning time went backwards, adjusting mod time of" \
> +			$(basename "$p")
> +		    touch -d @$(expr $ct + 60) "$p" || touch "$p"
> +		fi
> +
>  		# must strip nano-second part otherwise git gets very
>  		# confused, and makes up strange timestamps from the past
>  		# (chances are it decides to interpret it as a unix
> -- 
> 1.7.0.4
> 
-- 
UNIX is user-friendly ... it's just selective about who its friends are
Previous: jeffpc@josefsipek.netNext: Theodore Tso
Message 4 of 19 in “guilt: Make sure the commit time is increasing”
  1. guilt: Make sure the commit time is increasingTheodore Ts'o, Jul 5, 2010
  2. tytso@mit.eduJul 5, 2010
  3. jeffpc@josefsipek.netJul 5, 2010
  4. jeffpc@josefsipek.netJul 5, 2010
  5. Theodore TsoJul 5, 2010
  6. jeffpc@josefsipek.netJul 5, 2010
  7. tytso@mit.eduJul 5, 2010
  8. Jonathan NiederJul 6, 2010
  9. Theodore TsoJul 6, 2010
  10. Jonathan NiederJul 6, 2010
  11. tytso@mit.eduJul 6, 2010
  12. Jonathan NiederJul 6, 2010
  13. Erik Faye-LundJul 6, 2010
  14. Jeff KingJul 6, 2010
  15. Erik Faye-LundJul 6, 2010
  16. tytso@mit.eduJul 6, 2010
  17. jeffpc@josefsipek.netJul 6, 2010
  18. tytso@mit.eduJul 6, 2010
  19. Josef 'Jeff' SipekJul 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.