Re: [PATCH 0/3] git bisect visualize: find gitk on Windows again
On Thu, 3 Aug 2023, Junio C Hamano wrote:
Show 20 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>
>> writes:
>>
>>> Louis Strous reported a regression in git bisect visualize on Windows[1]
>>> that caused git bisect visualize to use git log instead of gitk unless
>>> explicitly called as git bisect visualize gitk.
>>>
>>> This patch series fixes that regression.
>>
>> Wonderful. It would be nice to describe where in the release
>> sequence the "regression" happened, if we know it. Perhaps you've
>> written about it in one of the patches? We'll find out.
>>
>> Thanks again.
>
> And the answer was in [2/3], if I am reading the proposed log
> messages correctly. When the "bisect visualize" was ported to C, we
> broke it.
>
> Thanks. Will try to queue based on 'maint'.
>
Please wait a moment, I'm currently preparing a V2 based on your feedback.