Re: [PATCH v2 3/3] docs: update when `git bisect visualize` uses `gitk`
- From
Matthias Aßhauer <mha1993@live.de>
- Date
- Aug 4, 2023, 05:54 UTC
- Message-ID
- <DB9P250MB06922EB40B40F07DBAA1441EA509A@DB9P250MB0692.EURP250.PROD.OUTLOOK.COM>
- In-Reply-To
- <CAPig+cTE__6B3RNbew8sHQQC3ELi9YAArYX5ofXRpMPBzZfmrw@mail.gmail.com>
On Fri, 4 Aug 2023, Eric Sunshine wrote:
Show 23 quoted lines
> On Fri, Aug 4, 2023 at 1:22 AM Matthias Aßhauer via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> This check has involved more environment variables than just `DISPLAY` since >> 508e84a790 (bisect view: check for MinGW32 and MacOSX in addition to X11, >> 2008-02-14), so let's update the documentation accordingly. >> >> Signed-off-by: Matthias Aßhauer <mha1993@live.de> >> --- >> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt >> @@ -204,9 +204,14 @@ as an alternative to `visualize`): >> -If the `DISPLAY` environment variable is not set, 'git log' is used >> -instead. You can also give command-line options such as `-p` and >> -`--stat`. >> +Git detects a graphical environment through various environment variables: >> +`DISPLAY`, which is set in X Window System environments on Unix systems. >> +`SESSIONNAME`, which is set under Cygwin in interactive desktop sessions. >> +`MSYSTEM`, which is set under Msys2 and Git for Windows. >> +`SECURITYSESSIONID`, which is set on macOS in interactive desktop sessions. > > Micronit: SECURITYSESSIONID is not universal on macOS[1]; some people > report its presence in iTerm2 and HyperTerm, and perhaps even Apple's > own Terminal (although it's not defined for me in Terminal on High > Sierra). Perhaps just say "may be set on macOS".
I've just checked in Terminal on Ventura and it isn't set for me either. I'll reword it.
> Probably not worth a reroll. > > [1]: https://github.com/vercel/hyper/issues/482 >