AW: [PATCH] gitk: fix history window panes position

From: tobias.boesch@miele.com <tobias.boesch@miele.com>
Date: Dec 4, 2025, 08:39 UTC
Message-ID: <DB8PR08MB5433FCF25C0693952E0E67BEE1A6A@DB8PR08MB5433.eurprd08.prod.outlook.com>
In-Reply-To: <9a9441d5-fb64-4718-8765-852e66458598@kdbg.org>

Some quick responses inlined below. I'll look into the rest of your annotations and try to directly provide a second version of the patch.

Show 21 quoted lines

> -----Ursprüngliche Nachricht-----
> Von: Johannes Sixt <j6t@kdbg.org>
> Gesendet: Mittwoch, 3. Dezember 2025 11:15
> An: Boesch, Tobias <tobias.boesch@miele.com>
> Cc: Git Mailing List <git@vger.kernel.org>
> Betreff: Re: [PATCH] gitk: fix history window panes position
>
> Am 02.12.25 um 14:08 schrieb tobias.boesch@miele.com:
> > From: Tobias Boesch <tobias.boesch@miele.com>
> > Date: Thu, 27 Nov 2025 11:27:16 +0100
> > Subject: [PATCH] gitk: fix history window panes position
> >
> > When the history window panes in are resized by moving either of the
> > two sashes and then the gitk window is vertically resized, the sashes
> > fall back into their previous position without respecting the users
> > wish for resizing.
>
> You say "the Gitk windows is resized vertically". Did you mean "resized
> horizontally"? If I change only the height of the Gitk window, the widths of the
> top panel (history, author, date) aren't changed at all.
> However, if I change only the width, the symptoms do occur.

You're right. I meant horizontally. Will be changed in the commit message.

>
> Also, the error is not limited to the upper half of the window. The lower panel
> (patch text, file list) also forgets the last used position when the window size is
> changed. Can we fix this, too?

Yes I plan to do that, but I thought it would be too big for one commit since it is a slightly different part of the app. I wanted to put this in a separate patch, since I just started with using emails and the git mailing list directly instead of using gitgitgadjet. That's all new to me and I didn't want to start with a series of patches on this first try. Would you like to have that fix in this patch and convert this patch into a series (somehow) or is it okay to put it in a separate patch?

Tobias

------------------------------------------------------------------------------------------------- imperial-Werke oHG, Sitz Bünde, Registergericht Bad Oeynhausen - HRA 4825