Re: [PATCH] gitk: fix history window panes position

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 4, 2025, 09:20 UTC
Message-ID: <9f7af47a-ae39-4931-805d-f6e4549231ac@kdbg.org>
In-Reply-To: <DB8PR08MB5433FCF25C0693952E0E67BEE1A6A@DB8PR08MB5433.eurprd08.prod.outlook.com>

Am 04.12.25 um 09:39 schrieb tobias.boesch@miele.com:

Show 12 quoted lines

>> Von: Johannes Sixt <j6t@kdbg.org>
>> Also, the error is not limited to the upper half of the window. The lower panel
>> (patch text, file list) also forgets the last used position when the window size is
>> changed. Can we fix this, too?
> 
> Yes I plan to do that, but I thought it would be too big for one commit since it is
> a slightly different part of the app.
> I wanted to put this in a separate patch, since I just started with using emails and
> the git mailing list directly instead of using gitgitgadjet. That's all new to me and
> I didn't want to start with a series of patches on this first try.
> Would you like to have that fix in this patch and convert this patch into a series
> (somehow) or is it okay to put it in a separate patch?

It depends on the solution needed. If they are the same approach, it can be a single patch. Otherwise, a separate patch may make sense.

BTW, the email that I received was not usable for git-am because its body was base64-encoded. I had to copy the text from my MUA to a text file before I could apply it with git-am. If you have trouble sending out unencoded, raw text mails, please use Gitgitgadget if there is more than one patch in the series.

-- Hannes