git/list[1] front-page[2] threads[3] people[4] search[5] about
 

definition for _attribute() in remote.c

From
Philip Oakley <philipoakley@iee.org>
Date
Apr 25, 2016, 21:02 UTC
Message-ID
<D7C0C4062A7242B6912E56480CBB06F4@PhilipOakley>
Hi,

I'm looking at getting Git for Windows to compile via Visual Studio (https://github.com/git-for-windows/git/pull/256).

However the use of __attribute() in remote.c at L1662 (https://github.com/git-for-windows/git/blob/master/remote.c#L1662) has got me confused in that I can't see how the regular definition of __attribute() is #included in this case. A definition is given in git\compat\regex\regex_internal.h but doesn't appear to be on remote.c's include path.

The line was introduced by 3a429d0 (remote.c: report specific errors from branch_get_upstream, 2015-05-21) which appears to be later than the previous MSVC testers had looked at.

Any guidance on what is happening in this case would be welcomed as this is the last compile error I'm seeing.

--
Philip
Next: Jeff King
Message 1 of 8 in “definition for _attribute() in remote.c”
  1. Philip OakleyApr 25, 2016
  2. Jeff KingApr 25, 2016
  3. remote.c: spell __attribute__ correctlyJeff King, Apr 25, 2016
  4. Philip OakleyApr 25, 2016
  5. Ramsay JonesApr 25, 2016
  6. Philip OakleyApr 26, 2016
  7. Philip OakleyApr 25, 2016
  8. Jeff KingApr 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.