Re: [PATCH] remote.c: spell __attribute__ correctly
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Apr 26, 2016, 13:19 UTC
- Message-ID
- <05BBD86AE63E4FA0ADE63F05DBD834C0@PhilipOakley>
- In-Reply-To
- <571E96CE.80606@ramsayjones.plus.com>
Thnx, From: "Ramsay Jones" <ramsay@ramsayjones.plus.com>
Show 25 quoted lines
> On 25/04/16 22:50, Philip Oakley wrote: >> From: "Jeff King" <peff@peff.net> >>> On Mon, Apr 25, 2016 at 05:10:30PM -0400, Jeff King wrote: >>> >>>> It should be handled in git-compat-util.h, which is included by >>>> cache.h, >>>> which is included by remote.c. >>>> >>>> There we have: >>>> >>>> #ifndef __GNUC__ >>>> #ifndef __attribute__ >>>> #define __attribute__(x) >>>> #endif >>>> #endif >>>> >>>> which should make it a noop on compilers which don't know about it. Is >>>> VS (or another file) setting __GNUC__? >>> >>> Of course it helps if we spell the name right... > > Indeed! ;-) > > Not that it matters, but the above #define in git-compat-util.h is not > the relevant definition - msvc will not see it.
Ah, I see that that block is further guarded with other if/elif/else clauses so that it's not seen if _MSC_VER is defined.
git-compat-util.h#L400-411
Show 6 quoted lines
> However, it does see > the #define on line 12 of compat/msvc.h. :-D > > ATB, > Ramsay Jones >