Re: Feature Request: Interactively pick fixup revision

From: Matěj Cepl <mcepl@cepl.eu>
Date: Nov 11, 2024, 02:53 UTC
Message-ID: <D5J0DCN2Y2V1.3C2JLTMGY8VAM@cepl.eu>
In-Reply-To: <CABg7He0upi8kmagGO13UMwSWOLeHoryZQU5CGsfbhgqedBKw=Q@mail.gmail.com>

On Sun Nov 10, 2024 at 8:55 AM CET, Martin Imre wrote:

> Just as a general question: With 2 (or even more) different
> implementations that solve the same problem, wouldn’t this be a good
> addition for a future version of git?

There are few problems, one which is the implementation language: git-absorb is Rust and git-fixup is bash (using arrays and other non-POSIX constructs).

Documentation/howto/new-command.txt declares:

    Most subcommands are written in C or shell.  A few are written in
    Perl.

    (And Python scripts are allowed for some specific tasks, namely GUI)

Shell script here quite emphatically means POSIX shell (or at least not using widely non-POSIX constructs like arrays), not bash. In order to even be able to consider any of these commands to be submitted to git proper, it would have to be ported first.

Best,

Matěj

-- 
http://matej.ceplovi.cz/blog/, @mcepl@floss.social
GPG Finger: 3C76 A027 CA45 AD70 98B5  BC1D 7920 5802 880B C9D8
 
Never ascribe to malice that which is adequately explained by
stupidity.
    -- Napoleon Bonaparte (or many other people to whom this
       quote is ascribed)