git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: Feature Request: Interactively pick fixup revision

From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date
Nov 9, 2024, 13:09 UTC
Message-ID
<03c201db32a8$96e66e20$c4b34a60$@nexbridge.com>
In-Reply-To
<CABg7He2asYQbdRvSvfh1YZ2FRPchVfvta8yBv4PFdVNnhzX6Ow@mail.gmail.com>
On November 9, 2024 6:41 AM, Martin Imre wrote:
Show 24 quoted lines
>first email to this list, so please forgive me if I'm doing something wrong.
>
>My usual workflow is using `git commit --fixup <revision>` quite frequently, as it
>eases the code reviewing process and allows for a clean history later on.
>
>One thing that is always cumbersome is to first find the SHA of the revision that I
>plan to commit a fixup to.
>I usually use git log and then copy the revision.
>I even wrote a script that eases this process using fzf:
>```
>#!/bin/bash
>
>res=$(git log --oneline | fzf)
>ref=$(echo $res | cut -d ' ' -f1)
>
>git commit --fixup ${ref}
>```
>
>I don't think fzf is really necessary here, but it speeds things up.
>
>Anyhow, I'm really surprised that this isn't a feature of git.
>I could see a `git commit --fixup` (without a revision) or `git commit --fixup --
>interactive` open up the git log and let one pick the revision they want to commit a
>fixup to.

You might find that git rebase --autosquash -i <commit> might do what you are looking for. This allows you to clean up your topic branch prior to creating a pull request. Loads of documentation online about its use.

Good luck, Randall

Previous: Martin ImreNext: Martin Imre
Message 2 of 12 in “Feature Request: Interactively pick fixup revision”
  1. Martin ImreNov 9, 2024
  2. rsbecker@nexbridge.comNov 9, 2024
  3. Martin ImreNov 9, 2024
  4. Matěj CeplNov 9, 2024
  5. Kristoffer HaugsbakkNov 9, 2024
  6. Matěj CeplNov 9, 2024
  7. Martin ImreNov 10, 2024
  8. Kristoffer HaugsbakkNov 10, 2024
  9. Stefan HallerNov 10, 2024
  10. Matěj CeplNov 11, 2024
  11. Oswald BuddenhagenNov 16, 2024
  12. Kristoffer HaugsbakkNov 9, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.