Re: [PATCH] GSoC2014 microprojects #6 Change bundle.c:add_to_ref_list() to use ALLOC_GROW()

From: Philip Oakley <philipoakley@iee.org>
Date: Feb 27, 2014, 16:18 UTC
Message-ID: <D5ECFBC97E4246CBB939B7670259D3DC@PhilipOakley>
In-Reply-To: <1393517894-670-1-git-send-email-sunheehnus@gmail.com>

From: "Sun He" <sunheehnus@gmail.com>

Show 23 quoted lines

>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
> bundle.c |    6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/bundle.c b/bundle.c
> index 7809fbb..1a7b7eb 100644
> --- a/bundle.c
> +++ b/bundle.c
> @@ -14,11 +14,7 @@ static const char bundle_signature[] = "# v2 git 
> bundle\n";
> static void add_to_ref_list(const unsigned char *sha1, const char 
> *name,
>  struct ref_list *list)
> {
> - if (list->nr + 1 >= list->alloc) {
> - list->alloc = alloc_nr(list->nr + 1);
> - list->list = xrealloc(list->list,
> - list->alloc * sizeof(list->list[0]));
> - }
> +    ALLOC_GROW(list->list,list->nr,list->alloc);
>  hashcpy(list->list[list->nr].sha1, sha1);

Isn't this on top of your other micro-project patch?

If so, it is worth including a note after your signoff and --- to say that, so they get applied in the right order :: The principle of least surprise.

Show 6 quoted lines

>  list->list[list->nr].name = xstrdup(name);
>  list->nr++;
> -- 
> 1.7.1
>
> --

Philip