Re: [PATCH] GSoC2014 microprojects #6 Change bundle.c:add_to_ref_list() to use ALLOC_GROW()

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Feb 27, 2014, 21:51 UTC
Message-ID: <530FB36D.6060103@alum.mit.edu>
In-Reply-To: <1393517894-670-1-git-send-email-sunheehnus@gmail.com>

On 02/27/2014 05:18 PM, Sun He wrote:

Show 23 quoted lines

> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>  bundle.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/bundle.c b/bundle.c
> index 7809fbb..1a7b7eb 100644
> --- a/bundle.c
> +++ b/bundle.c
> @@ -14,11 +14,7 @@ static const char bundle_signature[] = "# v2 git bundle\n";
>  static void add_to_ref_list(const unsigned char *sha1, const char *name,
>  		struct ref_list *list)
>  {
> -	if (list->nr + 1 >= list->alloc) {
> -		list->alloc = alloc_nr(list->nr + 1);
> -		list->list = xrealloc(list->list,
> -				list->alloc * sizeof(list->list[0]));
> -	}
> +    ALLOC_GROW(list->list,list->nr,list->alloc);
>  	hashcpy(list->list[list->nr].sha1, sha1);
>  	list->list[list->nr].name = xstrdup(name);
>  	list->nr++;
>

Many of my comments about the formatting of your other patches apply here. Also, we put spaces after ",", as you can see in the very next line.

I'm also pretty sure there is a serious error in your code. But I'd rather you stick to one microproject and get it perfect rather than do them all--especially all at once, with no time to incorporate feedback from one microproject into the attempt at the next one.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/