Re: [PATCH v2 1/5] worktree: add CLI/config options for relative path linking
- From
Caleb White <cdwhite3@pm.me>
- Date
- Oct 30, 2024, 20:36 UTC
- Message-ID
- <D59FG357FL61.909ECKSHV9MM@pm.me>
- In-Reply-To
- <0f91514a-f1cb-40da-a398-56d0fe37600e@gmail.com>
On Wed Oct 30, 2024 at 3:30 PM CDT, phillip.wood123 wrote:
Show 20 quoted lines
> On 30/10/2024 20:21, Caleb White wrote: >> If I created a getter/setter then the variable would no longer be >> extern'd. >> >> To be clear, you're advocating that I change the function signature >> for all of the functions listed above to include the new parameter? That >> seems like a lot of parameter bloat > > It's a bit of a pain to have to change the function signatures and pass > the parameter down but it's not difficult to do. > >> when I could just set the variable >> in this compilation unit and access it directly in the >> `write_worktree_linking_files()` function. > > The problem with that is that the variable is still effectively global. > The aim of the libification work is to be able to work on more than one > repository from a single process while respecting each repository's > config settings. >
I see your point. I'll make the changes you've suggested. Thanks for the feedback.
Best, Caleb