Re: [PATCH v2 0/5] Allow relative worktree linking to be configured by the user

From: Caleb White <cdwhite3@pm.me>
Date: Oct 30, 2024, 05:13 UTC
Message-ID: <D58VTT1HI35K.P2AJ7CC0FK@pm.me>
In-Reply-To: <2ce3998f-ea16-4fd4-9756-c5849d834b1e@gmail.com>

On Tue Oct 29, 2024 at 9:55 AM CDT, Phillip Wood wrote:

Show 9 quoted lines

> Hi Caleb
>
> Thanks for working on this. I've left so high-level comments on the
> first three patches. As I said in my comments on patch 1 I think it
> would be helpful to re-order the changes so that the extension is
> implementation first and then adjust the implementation to support both
> relative and absolute paths before adding "--no-relative-paths" to "git
> worktree add/move/repair". I'd also like to avoid adding a new global
> variable

Thanks for your review! I appreciate it :).

I'll address your comments on the first three patches and get back to you with a revised series.

Best, Caleb