git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/17] Make the msvc-build scripts work again

From
Philip Oakley <philipoakley@iee.org>
Date
Jun 25, 2015, 19:31 UTC
Message-ID
<D5232F937FAC41C89F2DB0806A5ABE7B@PhilipOakley>
In-Reply-To
<xmqqh9pv258w.fsf@gitster.dls.corp.google.com>
From: "Junio C Hamano" <gitster@pobox.com>
Show 10 quoted lines
> Philip Oakley <philipoakley@iee.org> writes:
>
>> Hopefully it's not too late in the cycle for a review of this 
>> contrib/compat
>> item.
>
> Has this been discussed in the Windows land and folks are all happy
> with this change?  If so the only thing we would need review on the
> main list is the top-level change outside compat/ and contrib/, so
> it may be possible to sneak it in before -rc1.

Yes this had been discussed previously on the MsysGit list, and in the referenced Pull Request [msysgit/#318] https://github.com/msysgit/git/pull/318/files.

I had aspirations of a slightly bigger series that would also allow the VS compiled output to be installed but that had stalled, so I cut back to fixing the basic 'make it work' steps.

The series has been reordered/rebased, and the recently noticed 05/17 err msg fix added.

The one unknown is the last patch [17] for the Windows Safe Exception Handling in that the default acceptability was flipped in VS2013 so that zlib became unacceptable to ceratain OS versions without the addition of that option -SAFESEH:NO, but I haven't been able to test that myself (I don't have a complaining system).

Show 41 quoted lines
>
> Otherwise, no, but we can still polish it during the prerelease
> freeze and aim to merge it in the first batch after the upcoming
> release.
>
>
>> Philip Oakley (17):
>>   .gitignore: improve MSVC ignore patterns
>>   .gitignore: ignore library directories created by MSVC VS2008
>>     buildsystem
>>   (msvc-build) Vcproj.pm: remove duplicate GUID
>>   Makefile: a dry-run can error out if no perl. Document the issue
>>   engine.pl: fix error message (lib->link)
>>   engine.pl: Avoid complications with perl support
>>   engine.pl: Properly accept quoted spaces in filenames
>>   engine.pl: Fix i18n -o option in msvc buildsystem generator
>>   engine.pl: ignore invalidcontinue.obj which is known to MSVC
>>   engine.pl: name the msvc buildsystem's makedry error file
>>   engine.pl: delete the captured stderr file if empty
>>   engine.pl: add debug line to capture the dry-run
>>   engine.pl: provide more debug print statements
>>   Vcproj.pm: list git.exe first to be startup project
>>   vcbuild/readme: Improve layout and reference msvc-build script
>>   msvc-build: add complete Microsoft Visual C compilation script
>>   config.mak.uname: add MSVC No_SafeExeceptionHandler option
>>
>>  .gitignore                                |  8 ++-
>>  Makefile                                  |  3 ++
>>  compat/vcbuild/README                     | 27 +++++++---
>>  compat/vcbuild/scripts/msvc-build         | 89 
>> +++++++++++++++++++++++++++++++
>>  config.mak.uname                          |  9 ++++
>>  contrib/buildsystems/Generators/Vcproj.pm | 34 ++++++------
>>  contrib/buildsystems/engine.pl            | 37 ++++++++++---
>>  7 files changed, 174 insertions(+), 33 deletions(-)
>>  create mode 100644 compat/vcbuild/scripts/msvc-build
>
>
>>  mode change 100755 => 100644 contrib/buildsystems/engine.pl
>
> Why?
Mistake on/by Windows? - My mistake, I hadn't noticed it had happened.
I can search out the change step and re-roll.
> --
Philip 
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Junio C Hamano
Message 34 of 34 in “Make the msvc-build scripts work again”
  1. 00/17 Make the msvc-build scripts work againPhilip Oakley, Jun 25, 2015
  2. 01/17 .gitignore: improve MSVC ignore patternsPhilip Oakley, Jun 25, 2015
  3. Junio C HamanoJun 25, 2015
  4. Philip OakleyJun 25, 2015
  5. Junio C HamanoJun 25, 2015
  6. 02/17 .gitignore: ignore library directories created by MSVC VS2008 buildsystemPhilip Oakley, Jun 25, 2015
  7. 03/17 (msvc-build) Vcproj.pm: remove duplicate GUIDPhilip Oakley, Jun 25, 2015
  8. Eric SunshineJun 28, 2015
  9. Philip OakleyJun 28, 2015
  10. 04/17 Makefile: a dry-run can error out if no perl. Document the issuePhilip Oakley, Jun 25, 2015
  11. Junio C HamanoJun 25, 2015
  12. Philip OakleyJun 25, 2015
  13. Junio C HamanoJun 25, 2015
  14. Philip OakleyJun 25, 2015
  15. Philip OakleyJul 14, 2015
  16. 05/17 engine.pl: fix error message (lib->link)Philip Oakley, Jun 25, 2015
  17. 06/17 engine.pl: Avoid complications with perl supportPhilip Oakley, Jun 25, 2015
  18. 07/17 engine.pl: Properly accept quoted spaces in filenamesPhilip Oakley, Jun 25, 2015
  19. 08/17 engine.pl: Fix i18n -o option in msvc buildsystem generatorPhilip Oakley, Jun 25, 2015
  20. 09/17 engine.pl: ignore invalidcontinue.obj which is known to MSVCPhilip Oakley, Jun 25, 2015
  21. 10/17 engine.pl: name the msvc buildsystem's makedry error filePhilip Oakley, Jun 25, 2015
  22. 11/17 engine.pl: delete the captured stderr file if emptyPhilip Oakley, Jun 25, 2015
  23. 12/17 engine.pl: add debug line to capture the dry-runPhilip Oakley, Jun 25, 2015
  24. 13/17 engine.pl: provide more debug print statementsPhilip Oakley, Jun 25, 2015
  25. Sebastian SchuberthJun 29, 2015
  26. Philip OakleyJul 7, 2015
  27. Sebastian SchuberthJun 29, 2015
  28. Sebastian SchuberthJun 29, 2015
  29. 14/17 Vcproj.pm: list git.exe first to be startup projectPhilip Oakley, Jun 25, 2015
  30. 15/17 vcbuild/readme: Improve layout and reference msvc-build scriptPhilip Oakley, Jun 25, 2015
  31. 16/17 msvc-build: add complete Microsoft Visual C compilation scriptPhilip Oakley, Jun 25, 2015
  32. 17/17 config.mak.uname: add MSVC No_SafeExeceptionHandler optionPhilip Oakley, Jun 25, 2015
  33. Junio C HamanoJun 25, 2015
  34. Philip OakleyJun 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.