Re: [PATCH 04/17] Makefile: a dry-run can error out if no perl. Document the issue

From: Philip Oakley <philipoakley@iee.org>
Date: Jun 25, 2015, 23:34 UTC
Message-ID: <45344004B4CA4B16BD7FB174B4849D77@PhilipOakley>
In-Reply-To: <xmqqmvzny1xe.fsf@gitster.dls.corp.google.com>

From: "Junio C Hamano" <gitster@pobox.com>

Show 20 quoted lines

> "Philip Oakley" <philipoakley@iee.org> writes:
>
>> From: "Junio C Hamano" <gitster@pobox.com>
>>>
>>> I am not sure what this patch is trying to achieve.
>>
>> It was probably a bit of 'don't mess with working code', given that
>> I'd used the NO_PERL solution, rather 'document the issue'....
>
> Then this part applies, I think.
>
>>> If you are not touching what this Makefile actually does, then I
>>> would imagine that you are running the "buildsystems code" that
>>> actually drives 'make -n' with some "available solution" (perhaps
>>> you are running 'make -n NO_PERL=NoThanks' or something like that)?
>>> Then instead of a command like this that nobody would read in this
>>> file, the same command can instead go there to explain what the
>>> "workaround" (e.g. unusual-looking 'make -n NO_PERL=NoThanks') is
>>> doing?
>

I was more of the view that this was about prevention (here), rather than retrospective explanation of the code (there).

In my case the errors were showing problems with the PM.stamp in the makefile (I didn't have the solution at that point).

So either a short comment "# consider using 'NO_PERL=YesPlease' for dry run invocations" (beware your double negative ;-), or the addition of the '+recipe', would still be my preferred change, rather than leaving the open manhole for others to fall into.

The thread on my difficulties is at $gmane/263656 (2015-02-10 22:51)
"
    At the moment I'm getting (on my old WinXP machine, using Msysgit
    1.9.5 as a basis)

    $ make -n MSVC=1 V=1 1>makedry.txt
    make[1]: *** No rule to make target `PM.stamp', needed by 
`perl.mak'.
    Stop.
    make: *** [perl/perl.mak] Error 2
"
As you can see, at that time the place to look would be the makefile,
so I would do think a 'fix' there would still be appropriate.

Do you have a preference among the three options (comment, +recipe, drop)? -- Philip

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.