Re: [PATCH] WinGit: include html pages from official git.git's html branch

From: Steffen Prohaska <prohaska@zib.de>
Date: Sep 30, 2007, 08:19 UTC
Message-ID: <D4E42E0D-99CB-4F4E-AC89-CD94DA061FDC@zib.de>
In-Reply-To: <Pine.LNX.4.64.0709300022080.28395@racer.site>

On Sep 30, 2007, at 1:23 AM, Johannes Schindelin wrote:

Show 28 quoted lines

> Hi,
>
> On Sat, 29 Sep 2007, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>> On Sat, 29 Sep 2007, Steffen Prohaska wrote:
>>>
>>>> It is assumed that a matching version of the html documentation is
>>>> available as the HEAD of /doc/git/html/.git. If not an error  
>>>> will be
>>>> reported.
>>>>
>>>> This patch doesn't include a mechanism to fetch the html pages to
>>>> /doc/git/html/.git. You should manually clone them. Maybe this  
>>>> could
>>>> handled as a submodule of msysgit?
>>>
>>> I'd rather handle it as in git.git, as another branch, and not check
>>> it out in /git/html/, but rather use "git read-tree
>>> --prefix=/tmp/WinGit/share/git/html origin/html", or some such.
>>
>> This is starting to smell like an opportunity to use the gitlink  
>> stuff,
>> isn't it?
>
> I'd agree that we could have a submodule in /doc/git/html/.  This way,
> even users of msysGit and GitMe would benefit.

And we could completely tag a WinGit release. The version of the html docs included would be defined by the submodule's head in /doc/git/html. This is what I had in mind when submitting the patch. Maybe I didn't express this clearly.

I do not yet understand submodules sufficiently. Therefore I didn't add a patch that actually sets up the submodule in /doc/git/html. Maybe I'll do so later today.

	Steffen