git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Fix sed script to work with AIX and BSD sed.

From
Benoit Sigoure <tsuna@lrde.epita.fr>
Date
Nov 8, 2007, 22:15 UTC
Message-ID
<D42380BD-64A7-4686-9EC1-39F76D0C35D6@lrde.epita.fr>
In-Reply-To
<20071108214824.GH31439@ins.uni-bonn.de>
On Nov 8, 2007, at 10:48 PM, Ralf Wildenhues wrote:
Show 10 quoted lines
> diff --git a/git-bisect.sh b/git-bisect.sh
> index c18bd32..3aac816 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -276,7 +276,8 @@ exit_if_skipped_commits () {
>  	if expr "$_tried" : ".*[|].*" > /dev/null ; then
>  		echo "There are only 'skip'ped commit left to test."
>  		echo "The first bad commit could be any of:"
> -		echo "$_tried" | sed -e 's/[|]/\n/g'
> +		echo "$_tried" | sed -e 's/[|]/\

Just out of curiosity, is there any valid reason to use `[' and `]' in this RE? By default sed does not use extended RE (at least none of the implementation I know of) so why not just use sed 's/|/...' ?

> +/g'
>  		echo "We cannot bisect more!"
>  		exit 2
>  	fi
-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory
Previous: Ralf WildenhuesNext: Ralf Wildenhues
Message 4 of 5 in “some shell portability fixes, v2”
  1. 0/3 some shell portability fixes, v2Ralf Wildenhues, Nov 8, 2007
  2. 1/3 Avoid a few unportable, needlessly nested "...`...".Ralf Wildenhues, Nov 8, 2007
  3. 2/3 Fix sed script to work with AIX and BSD sed.Ralf Wildenhues, Nov 8, 2007
  4. Benoit SigoureNov 8, 2007
  5. 3/3 Fix sed string regex escaping in module_name.Ralf Wildenhues, Nov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.