git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] Fix sed script to work with AIX and BSD sed.

From
RWRalf Wildenhues <ralf.wildenhues@gmx.de>
Date
Nov 8, 2007, 21:48 UTC
Message-ID
<20071108214824.GH31439@ins.uni-bonn.de>
In-Reply-To
<20071108214624.GF31439@ins.uni-bonn.de>

\n is not portable in a s/// replacement string, only in the regex part. backslash-newline helps.

Signed-off-by: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
---
I'm a bit unsure whether you would prefer to avoid breaking the
indentation with something like
  tr '|' '\n'

OTOH, \n in a tr set is not universally portable either (for example Solaris /usr/ucb/tr mishandles it, and \012 fails on EBCDIC), but I'm still on my way of finding out the level of portability you prefer. ;-)

Cheers, Ralf

 git-bisect.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index c18bd32..3aac816 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -276,7 +276,8 @@ exit_if_skipped_commits () {
 	if expr "$_tried" : ".*[|].*" > /dev/null ; then
 		echo "There are only 'skip'ped commit left to test."
 		echo "The first bad commit could be any of:"
-		echo "$_tried" | sed -e 's/[|]/\n/g'
+		echo "$_tried" | sed -e 's/[|]/\
+/g'
 		echo "We cannot bisect more!"
 		exit 2
 	fi
-- 
1.5.3.5.561.g140d
Previous: Ralf WildenhuesNext: Benoit Sigoure
Message 3 of 5 in “some shell portability fixes, v2”
  1. 0/3 some shell portability fixes, v2Ralf Wildenhues, Nov 8, 2007
  2. 1/3 Avoid a few unportable, needlessly nested "...`...".Ralf Wildenhues, Nov 8, 2007
  3. 2/3 Fix sed script to work with AIX and BSD sed.Ralf Wildenhues, Nov 8, 2007
  4. Benoit SigoureNov 8, 2007
  5. 3/3 Fix sed string regex escaping in module_name.Ralf Wildenhues, Nov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.