Re: [PATCH 10/12] reftable/record: reuse refname when copying

From: James Liu <james@jamesliu.io>
Date: Feb 28, 2024, 00:08 UTC
Message-ID: <CZG9WY119NCG.2ID9DQE6T030U@jamesliu.io>
In-Reply-To: <d7311598c0f81ad3fa41560b54b0974d41485a23.1707895758.git.ps@pks.im>

On Wed Feb 14, 2024 at 6:46 PM AEDT, Patrick Steinhardt wrote:

Show 5 quoted lines

> +	SWAP(refname, ref->refname);
> +	SWAP(refname_cap, ref->refname_cap);
>  	reftable_ref_record_release(ref);
> +	SWAP(refname, ref->refname);
> +	SWAP(refname_cap, ref->refname_cap);

Likewise here, what are your thoughts about reversing the SWAP arguments for the last two invocations?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.