From: James Liu <james@jamesliu.io>
Date: Wed, 28 Feb 2024 00:08:42 GMT
Subject: Re: [PATCH 10/12] reftable/record: reuse refname when copying
Message-ID: <CZG9WY119NCG.2ID9DQE6T030U@jamesliu.io>
In-Reply-To: <d7311598c0f81ad3fa41560b54b0974d41485a23.1707895758.git.ps@pks.im>

On Wed Feb 14, 2024 at 6:46 PM AEDT, Patrick Steinhardt wrote:
> +	SWAP(refname, ref->refname);
> +	SWAP(refname_cap, ref->refname_cap);
>  	reftable_ref_record_release(ref);
> +	SWAP(refname, ref->refname);
> +	SWAP(refname_cap, ref->refname_cap);

Likewise here, what are your thoughts about reversing the SWAP arguments for
the last two invocations?