Re: [PATCH v2] hooks: add sendemail-validate-series

From: Robin Jarry <robin@jarry.cc>
Date: Apr 11, 2023, 10:39 UTC
Message-ID: <CRTV2BVL0265.1H9OALXHPDZF1@ringo>
In-Reply-To: <9b8d6cc4-741a-5081-d5de-df0972efec37@gmail.com>

Phillip Wood, Apr 11, 2023 at 11:58:

> A hook that wants to check some property of the whole series needs to 
> know which patch is the final one. We could pass that via the 
> environment as we do for external diff commands with 
> GIT_DIFF_PATH_COUNTER and GIT_DIFF_PATH_TOTAL.

That may be an appropriate solution and it would avoid adding another hook. And it would solve the issue of "\n" in filenames.

The only downside is that you would need to store state in an external file (maybe in GIT_DIR) so that successive calls of the hook script can pick up where the previous invocation ended.

It all comes down to ergonomics at this point. I don't mind either solutions as long as validating whole series is possible before sending emails.