Re: [PATCH RESEND] hooks: add sendemail-validate-series
- From
Robin Jarry <robin@jarry.cc>
- Date
- Apr 5, 2023, 08:31 UTC
- Message-ID
- <CROOKNR29PDV.1WIGA6219L1C6@ringo>
- In-Reply-To
- <xmqqbkk3z9p9.fsf@gitster.g>
Junio C Hamano, Apr 04, 2023 at 22:14:
> Feeding the filenames as the command line arguments would have been > much simpler X-<,
Just a thought. Instead of adding another hook, wouldn't it be better to add an option --validate-series (git config sendemail.validateSeries) that would change the behaviour of the sendemail-validate hook? Calling it with all patch files as command line arguments only once instead of once per file.
I know I was concerned with the max size of the command line args but is there really a chance that we hit that maximum? On my system, it is 2097152 bytes. Even with a 1000 patches series with 1000 bytes filenames, we wouldn't hit the limit.
This way, we support any crap filename that the user may send and we don't add a new hook which basically does the same thing than the existing one.
Thoughts?