RE: [PATCH v2 0/3] send-email: teach git send-email mode to translate aliases

From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Aug 15, 2024, 23:46 UTC
Message-ID: <CO1PR11MB50896A614BEE7E54A6105E1CD6802@CO1PR11MB5089.namprd11.prod.outlook.com>
In-Reply-To: <xmqqplq9qtrr.fsf@gitster.g>

Show 25 quoted lines

> -----Original Message-----
> From: Junio C Hamano <gitster@pobox.com>
> Sent: Thursday, August 15, 2024 3:57 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: git@vger.kernel.org; Jacob Keller <jacob.keller@gmail.com>; Konstantin
> Ryabitsev <konstantin@linuxfoundation.org>
> Subject: Re: [PATCH v2 0/3] send-email: teach git send-email mode to translate
> aliases
> 
> Jacob Keller <jacob.e.keller@intel.com> writes:
> 
> > Jacob Keller (3):
> >       t90001-send-email.sh: fix quoting for mailrc --dump-aliases test
> >       t9001-send-email.sh: update alias list used for pine test
> >       send-email: teach git send-email option to translate aliases
> 
> Seems to fail t9001 rather miserably on Windows.
> 
> https://github.com/git/git/actions/runs/10411559740/job/28835810137#step:5:24
> 44
> 
> There seem to be way too many PREREQ related skippage, it is not all
> that surprising (it does not make it excuable, though) if a new test
> that comes later and not skipped is broken because earlier steps are
> not executed.

It looks like we're missing the perl PREREQ on the tests, so these execute and then fail because of lack of perl. Should be easy to fix.