Re: [PATCH v2 2/3] t9001-send-email.sh: update alias list used for pine test

From: Jacob Keller <jacob.keller@gmail.com>
Date: Aug 14, 2024, 17:47 UTC
Message-ID: <CA+P7+xooHK-t0gEZyDeKAYYBvVJXdWyRHEOC4zok-C8+vLxqvw@mail.gmail.com>
In-Reply-To: <xmqqo75vyr4b.fsf@gitster.g>

On Wed, Aug 14, 2024 at 10:02 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

>
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
> > From: Jacob Keller <jacob.keller@gmail.com>
> >
> > The set of aliases used for the pine --dump-aliases test do not
> > perfectly mesh with the way the pine address book is defined. While
> > technically all valid, there are some oddities including bob's name
> > being partially split so that the actual address is returned as
> > "Bobbyton <bob@example.com".
>
> With "partially split" bob's name, do you mean the HT between Robert
> and Bobbyton in the original?
>
> I am asking to see if the closing angle-bracket ">" after the
> address is deliberately omitted to illustrate a breakage coming from
> a malformed entry in the original address book, or it is missing
> merely by mistake.
>

It is missing as a mistake, I think. The main change here is the HT between Robert and Bobbyton in the original was causing the fields to be separated.in what seemed like an unintentional way to me. The missing > was I think due to a copy-paste error where i failed to select the final > when copying to paste into the commit log.

> > -     bob     Robert  Bobbyton <bob@example.com>
> > +     bob     Robert Bobbyton bob@example.com
>
> Thanks.