Re: [GSoC][PATCH] git-ci: use pylint to analyze the git-p4 code

From: Lars Schneider <larsxschneider@gmail.com>
Date: Mar 12, 2018, 10:15 UTC
Message-ID: <CC42B5EC-6594-45CB-9821-E1C0ECED354E@gmail.com>
In-Reply-To: <20180312022003.8844-1-viethtran1620@gmail.com>

Hi Viet,

Show 6 quoted lines

> On 12 Mar 2018, at 03:20, Viet Hung Tran <viethtran1620@gmail.com> wrote:
> 
> This is my submission as a microproject for the Google Summer of code.
> I apologize for not setting the [GSoC] in my previous email
> at <20180312020855.7950-1-viethtran1620@gmail.com>.
> Please ignore it.

No worries :-)

> Add a new job named Pylint to .travis.yml in order to analyze git-p4 Python code.
> Although Travis CI have yet to implement continuous integration for multiple
> languages. Python package can be installed using apt packages. From there, pylint can be
> installed using pip and used to analyze git-p4.py file.

That looks interesting! I assume you did run this on TravisCI already? Can you share a link? I assume you did find errors? Can we fix them or are there too many? If there are existing errors, how do we define a "successful" build?

Thanks for working on this, Lars

Show 30 quoted lines

> 
> Signed-off-by: Viet Hung Tran <viethtran1620@gmail.com>
> ---
> .travis.yml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 5f5ee4f3b..581d75319 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -46,6 +46,16 @@ matrix:
>         - docker
>       before_install:
>       script: ci/run-linux32-docker.sh
> +    - env: jobname=Pylint
> +      compiler:
> +      addons:
> +        apt:
> +          packages:
> +          - python
> +      before_install:
> +      install: pip install --user pylint
> +      script: pylint git-p4.py
> +      after_failure:
>     - env: jobname=StaticAnalysis
>       os: linux
>       compiler:
> -- 
> 2.16.2.440.gc6284da
>