[GSoC][PATCH] git-ci: use pylint to analyze the git-p4 code

From: Viet Hung Tran <viethtran1620@gmail.com>
Date: Mar 13, 2018, 03:36 UTC
Message-ID: <20180313033643.7686-1-viethtran1620@gmail.com>
In-Reply-To: <CC42B5EC-6594-45CB-9821-E1C0ECED354E@gmail.com>

Hello Mr. Schneider,

Here is my link for the passed CI build I tested on my fork: https://travis-ci.org/VietHTran/git/builds/352103333

In order to test .travis.yml configuration alone, I used a sample python script call "test.py" that is already successfully tested on my computer instead of using the git-p4.py like in the patch I submitted since the git-p4.py file still reports a lot of errors when running pylint.

It is possible to fix all the git-p4.py errors. However, I think it would be best to fix each error separately with multiple commits (each should fix a specific problem such as indentication, variable naming, etc.) since there are a lot of changes needed to be made in the codes. Since the microproject requires that I submit one patch, I decided to submit a patch that includes changes in .travis.yml only. If you like, I can also submit the patches addressing changes on the git-p4.py that fix the pylint errors.

Thank you for feedback,

Viet

Signed-off-by: Viet Hung Tran <viethtran1620@gmail.com>
---
 .travis.yml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 5f5ee4f3b..581d75319 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -46,6 +46,16 @@ matrix:
         - docker
       before_install:
       script: ci/run-linux32-docker.sh
+    - env: jobname=Pylint
+      compiler:
+      addons:
+        apt:
+          packages:
+          - python
+      before_install:
+      install: pip install --user pylint
+      script: pylint git-p4.py
+      after_failure:
     - env: jobname=StaticAnalysis
       os: linux
       compiler:

-- 
2.16.2.440.gc6284da