Re: [PATCH v2] shell: allow overriding built-in commands
- From
Chris Torek <chris.torek@gmail.com>
- Date
- Mar 23, 2025, 15:12 UTC
- Message-ID
- <CAPx1GvfPUqHkT8MewXyAS5ptO2Cz+Jn1+1w9wa5j-WfO68dfYg@mail.gmail.com>
- In-Reply-To
- <11DFC309-0D48-42C8-A683-F5D0C30810D3@gmail.com>
On Sun, Mar 23, 2025 at 8:05 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
> Shouldn't we also check [access()] for both F_OK?
Any success for R_OK, W_OK, or X_OK implies F_OK.
I'm not a fan of access() calls in general for multiple reasons (they get suggested for security tests in setuid programs, but you race from "access seems OK" to "actually try to access" against anyone who modifies the name-to-underlying-entity binding, so in general the "right" test is "do the operation with the appropriate permissions in place, then see if it actually worked", which is atomic). But in this particular case it's probably not that important (we seem to make a lot of assumptions about security, or perhaps lack of its importance, in git-shell).
Chris