Re: [PATCH v2] shell: allow overriding built-in commands

From: Ayman Bagabas <ayman.bagabas@gmail.com>
Date: Mar 23, 2025, 15:05 UTC
Message-ID: <11DFC309-0D48-42C8-A683-F5D0C30810D3@gmail.com>
In-Reply-To: <CAPx1Gvd+0XBVm6N6Vrogczhqy8hARajoQ+zDgaaeKMTcSskmeA@mail.gmail.com>

Show 10 quoted lines

> On Mar 23, 2025, at 4:11 AM, Chris Torek <chris.torek@gmail.com> wrote:
> 
> I'm not at all sure about any security implications, but aside from that, I
> suspect this:
> 
> On Sat, Mar 22, 2025 at 5:13 PM Ayman Bagabas via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> +               if (!access(full_cmd, F_OK)) {
> 
> should use X_OK rather than F_OK.

Good catch!

Shouldn't we also check for both F_OK?

> 
> Chris