Re: [PATCH] revisions.txt: correct a mistake in dotted range notations section
- From
Chris Torek <chris.torek@gmail.com>
- Date
- Apr 26, 2023, 21:16 UTC
- Message-ID
- <CAPx1GverCci3SZQEMvFX_q7r3XSTKmPizfcj8QcvGNud7reY9g@mail.gmail.com>
- In-Reply-To
- <pull.1485.git.git.1682495081131.gitgitgadget@gmail.com>
On Wed, Apr 26, 2023 at 1:00 AM Pooyan Khanjankhani via GitGitGadget <gitgitgadget@gmail.com> wrote:
> From: Pooyan Khanjankhani <p.khanjankhani@digikala.com> > > Insert a missing 'not' word in a negative sentence. > ... but are [not] reachable from neither A or C.
There's a peculiarity of the English language here that means you should not use the word "not". The actual error is using "or" as the conjunction, instead of "nor": the construct should read "neither <alternative 1> nor <alternative 2>", and it means that both alternatives are rejected.
That said, there's almost certainly a reformulation that uses language less-confusing to non-native speakers. Perhaps this is better (I haven't actually made a commit of this, it's just a diff in place):
diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt index 9aa58052bc..5460820377 100644 --- a/Documentation/revisions.txt +++ b/Documentation/revisions.txt @@ -305,14 +305,14 @@ other, e.g. $ git log A..B C..D does *not* specify two revision ranges for most commands. Instead -it will name a single connected set of commits, i.e. those that are -reachable from either B or D but are reachable from neither A or C. -In a linear history like this: +it will name a single connected set of commits: those that are +reachable from either B or D, but not reachable from either A or C. +For example, in a linear history like this: ---A---B---o---o---C---D because A and B are reachable from C, the revision range specified -by these two dotted ranges is a single commit D. +by these two dotted ranges is the single commit D. Other <rev>{caret} Parent Shorthand Notations Chris